fix: make block query cutoff properly configurable#181
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Evalir
requested changes
Nov 21, 2025
Evalir
requested changes
Nov 21, 2025
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
Actually, disregard the other review. This should be called BLOCK_QUERY_CUTOFF_BUFFER
rswanson
reviewed
Nov 21, 2025
prestwich
requested changes
Nov 21, 2025
Member
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
seconds is not enough resolution. needs to be milliseconds
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
aa0fb98 to
48769bd
Compare
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
d6fa407 to
376d078
Compare
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
cb227d0 to
376d078
Compare
Closed
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
88c0627 to
c7121a6
Compare
Evalir
reviewed
Nov 25, 2025
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
I wonder if it's better to explicitly circuit break the building process altogether if the deadline ends up being too close to Instant::now() instead of this being implicit, because it indicates we've ran out of time anyway.
prestwich
reviewed
Nov 25, 2025
prestwich
reviewed
Nov 25, 2025
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
2 times, most recently
from
8ac4079 to
e782314
Compare
Evalir
reviewed
Dec 23, 2025
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
e782314 to
8199d03
Compare
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
8199d03 to
7575907
Compare
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
7575907 to
cd1c230
Compare
prestwich
reviewed
Jan 6, 2026
prestwich
reviewed
Jan 6, 2026
| desc = "Number of milliseconds before the end of the slot to stop querying for new transactions and start the block signing and submission process", | ||
| default = 3000 | ||
| )] | ||
| pub block_query_cutoff_buffer: u64, |
Member
There was a problem hiding this comment.
there's a minimum reasonable value here right? Which is that quincey will stop signing. we should document that the minimum exists, and then document the current quincey configuration in the builder section of signet.sh/docs
prestwich
reviewed
Jan 6, 2026
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
2 times, most recently
from
4b2cd52 to
cb62e32
Compare
dylanlott
force-pushed
the
dylan/fix-deadline-cutoff
branch
from
cb62e32 to
91df8a8
Compare
Evalir
approved these changes
Jan 7, 2026
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: make block query cutoff properly configurable
At some point in the past, the block query cutoff configuration value was removed and a hard-coded value was added in.
This PR adds the block query cutoff back into the config and uses the config value in the
calculate_deadline function.Builder example environment documentation needs to be updated to reflect this change.